-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg: Don't save empty posts #14329
Conversation
Show an alert if a post or page are empty.
GB can send this HTML when it only has a placeholder paragraph with no content at all.
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working good as described 🎉
Added a few comments on code. One alternative idea to check if the content is empty.
Let me know what do you think 👍
WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed on #14329 (comment), let's merge this to solve the main issue. Then we can improve the logic on a next PR.
Still let's wait for a ✅ on the text by @iamthomasbishop ?
Fixes wordpress-mobile/gutenberg-mobile#369
While creating this PR I noticed the following:
hasChanges
set to false when there is changes, this is also confusing the status of the Navigation Publish/Update button, thinking that the post has no changes when it has changes.To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.